Lexus is adjustment #192
Merged
Lexus is adjustment #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just checked one of my routes, and it definitely seems like the factor needs to be increased. 0.77 seems to fit better though. |
|
Ok, happy to merge 0.77. just remember to change it in interface.py as well if you drive with it. And flash panda :) |
|
@rbiasini awesome! updated! are you ok with the other 2 changes? :) |
|
Cabana graphs weren't working for me so I threw together this script. should help with other ports. |
rbiasini
reviewed
Oct 11, 2019
| SG_ STEER_TORQUE_DRIVER : 15|16@0- (1,0) [-32768|32767] "" XXX | ||
| SG_ STEER_OVERRIDE : 0|1@0+ (1,0) [0|1] "" XXX | ||
| SG_ CHECKSUM : 63|8@0+ (1,0) [0|255] "" XXX | ||
| SG_ STEER_ANGLE : 31|16@0- (0.056,0) [-500|500] "" XXX |
There was a problem hiding this comment.
0.573 is more correct (rad/100). I'll fix it in a separate commit
jyoung8607
pushed a commit
to jyoung8607/opendbc
that referenced
this pull request
Oct 17, 2019
* Add 581 for ISH gas pedal signal * Add STEER_ANGLE in 608 STEER_TORQUE_SENSOR (similar to TSS2) * Change STEER_TORQUE_EPS factor in 608 STEER_TORQUE_SENSOR to 1.0 * Re-generate lexus_is_2018 * reduce factor to 0.77
rbiasini
pushed a commit
that referenced
this pull request
Oct 17, 2019
* Update ACC_02.SetSpeed to use a more accurate m/s formula instead of kmh * Fixes to LWI vs EPS calculations for steering angles, clarify descriptions of each. * Endianness fixes * Add ESP_15 and PSD_04/05/06 * Testing PSD interpretation * Correct message info for ESP_08 * Additional authoritative message names and IDs * OpenDBC updates * OpenDBC updates * DBC cleanup, CRC support, restore VIN_01 mux lost during Cabana editing. * Add the PQ heading control assist message. * OpenDBC updates * Add a pointer to the VIN_1 mux. * Probable EPS_1 message * Add comment about rate-limiting on Getriebe_11 counter signal. * Rename CRC->CHECKSUM for upstream of a minimum viable VW port. Per my Discord talk with @rbiasini, to reduce OP core code diffs a bit, we will temporarily (ab)use CHECKSUM to store a CRC like Pedal is doing today. After the port is upstreamed, we will look at updating the core OP code to support dynamic CRC and counter signal names, and revert the DBC signal names back to canonical (MSG_NAME_CRC, MSG_NAME_BZ, etc). I will update the OP core CRC support PR shortly. * OpenDBC updates * OpenDBC updates * Probable EPS_1 message * Updates for Volkswagen support (#191) * Update ACC_02.SetSpeed to use a more accurate m/s formula instead of kmh * Fixes to LWI vs EPS calculations for steering angles, clarify descriptions of each. * Endianness fixes * Add ESP_15 and PSD_04/05/06 * Testing PSD interpretation * Correct message info for ESP_08 * Additional authoritative message names and IDs * OpenDBC updates * OpenDBC updates * DBC cleanup, CRC support, restore VIN_01 mux lost during Cabana editing. * Add the PQ heading control assist message. * Add a pointer to the VIN_1 mux. * Add comment about rate-limiting on Getriebe_11 counter signal. * Rename CRC->CHECKSUM for upstream of a minimum viable VW port. Per my Discord talk with @rbiasini, to reduce OP core code diffs a bit, we will temporarily (ab)use CHECKSUM to store a CRC like Pedal is doing today. After the port is upstreamed, we will look at updating the core OP code to support dynamic CRC and counter signal names, and revert the DBC signal names back to canonical (MSG_NAME_CRC, MSG_NAME_BZ, etc). I will update the OP core CRC support PR shortly. * Lexus is adjustment (#192) * Add 581 for ISH gas pedal signal * Add STEER_ANGLE in 608 STEER_TORQUE_SENSOR (similar to TSS2) * Change STEER_TORQUE_EPS factor in 608 STEER_TORQUE_SENSOR to 1.0 * Re-generate lexus_is_2018 * reduce factor to 0.77 * Fix steer angle factor for toyota * OpenDBC updates * Create luxgen_s5_2014.dbc (#101) * Create luxgen_s5_2015.dbc * Update luxgen_s5_2015.dbc * Update luxgen_s5_2015.dbc * fixed to luxgen dbc file * EV_Gearshift message * EV_Gearshift message for e-Golf support without a separate gearbox. * Corrected byte order on two signals. * Corrected byte order on several homebrewed VW MQB signals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
× Add 581 for ISH gas pedal signal
× Add STEER_ANGLE in 608 STEER_TORQUE_SENSOR (similar to TSS2)
× Change STEER_TORQUE_EPS factor in 608 STEER_TORQUE_SENSOR to 1.0